[Mlir-commits] [mlir] [MLIR] add C-API bindings for complex dialect (PR #173228)

[llvmlistbot at llvm.org]

Sergio =?utf-8?q?Sánchez_Ramírez?=,
Sergio =?utf-8?q?Sánchez_Ramírez?Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/173228 at github.com>


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Sergio Sánchez Ramírez (mofeing)

<details>
<summary>Changes</summary>

The `complex` dialect is missing from the MLIR's C-API. This PR adds the functions for registration of the dialect and handling of `complex::NumberAttr`.

---
Full diff: https://github.com/llvm/llvm-project/pull/173228.diff


3 Files Affected:

- (added) mlir/include/mlir-c/Dialect/Complex.h (+52) 
- (modified) mlir/lib/CAPI/Dialect/CMakeLists.txt (+9) 
- (added) mlir/lib/CAPI/Dialect/Complex.cpp (+44) 


``````````diff
diff --git a/mlir/include/mlir-c/Dialect/Complex.h b/mlir/include/mlir-c/Dialect/Complex.h
new file mode 100644
index 0000000000000..b5912cf457643
--- /dev/null
+++ b/mlir/include/mlir-c/Dialect/Complex.h
@@ -0,0 +1,52 @@
+//===-- mlir-c/Dialect/Complex.h - C API for Complex dialect ------*- C -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
+// Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef MLIR_C_DIALECT_COMPLEX_H
+#define MLIR_C_DIALECT_COMPLEX_H
+
+#include "mlir-c/IR.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+MLIR_DECLARE_CAPI_DIALECT_REGISTRATION(Func, func);
+
+/// Checks whether the given attribute is a complex attribute.
+MLIR_CAPI_EXPORTED bool mlirAttributeIsAComplex(MlirAttribute attr);
+
+/// Creates a complex attribute in the given context with the given
+/// double real and imaginary values and double-precision FP semantics.
+MLIR_CAPI_EXPORTED MlirAttribute mlirComplexAttrDoubleGet(MlirContext ctx,
+                                                        MlirType type,
+                                                        double real,
+                                                        double imag);
+
+/// Same as "mlirComplexAttrDoubleGet", but if the type is not valid for a
+/// construction of a ComplexAttr, returns a null MlirAttribute.
+MLIR_CAPI_EXPORTED MlirAttribute
+mlirComplexAttrDoubleGetChecked(MlirLocation loc, MlirType type, double real,
+                                double imag);
+
+/// Returns the real value stored in the given complex attribute, interpreting
+/// the value as double.
+MLIR_CAPI_EXPORTED double mlirComplexAttrGetRealDouble(MlirAttribute attr);
+
+/// Returns the imaginaryvalue stored in the given complex attribute,
+/// interpreting the value as double.
+MLIR_CAPI_EXPORTED double mlirComplexAttrGetImagDouble(MlirAttribute attr);
+
+/// Returns the typeID of a Complex attribute.
+MLIR_CAPI_EXPORTED MlirTypeID mlirComplexAttrGetTypeID(void);
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif // MLIR_C_DIALECT_COMPLEX_H
diff --git a/mlir/lib/CAPI/Dialect/CMakeLists.txt b/mlir/lib/CAPI/Dialect/CMakeLists.txt
index bb1fdf8be3c8f..30c9cb0593371 100644
--- a/mlir/lib/CAPI/Dialect/CMakeLists.txt
+++ b/mlir/lib/CAPI/Dialect/CMakeLists.txt
@@ -31,6 +31,15 @@ add_mlir_upstream_c_api_library(MLIRCAPIAsync
   MLIRPass
 )
 
+add_mlir_upstream_c_api_library(MLIRCAPIComplex
+  Complex.cpp
+
+  PARTIAL_SOURCES_INTENDED
+  LINK_LIBS PUBLIC
+  MLIRCAPIIR
+  MLIRComplexDialect
+)
+
 add_mlir_upstream_c_api_library(MLIRCAPIControlFlow
   ControlFlow.cpp
 
diff --git a/mlir/lib/CAPI/Dialect/Complex.cpp b/mlir/lib/CAPI/Dialect/Complex.cpp
new file mode 100644
index 0000000000000..0b1f5e477bab3
--- /dev/null
+++ b/mlir/lib/CAPI/Dialect/Complex.cpp
@@ -0,0 +1,44 @@
+//===- Complex.cpp - C Interface for Complex dialect ----------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "mlir-c/Dialect/Complex.h"
+#include "mlir-c/IR.h"
+#include "mlir-c/Support.h"
+#include "mlir/CAPI/Registration.h"
+
+MLIR_DEFINE_CAPI_DIALECT_REGISTRATION(Complex, complex,
+                                     mlir::complex::ComplexDialect)
+
+bool mlirAttributeIsAComplex(MlirAttribute attr) {
+  return llvm::isa<ComplexAttr>(unwrap(attr));
+}
+
+MlirAttribute mlirComplexAttrDoubleGet(MlirContext ctx, MlirType type,
+                                       double real, double imag) {
+  return wrap(
+      complex::NumberAttr::get(cast<ComplexType>(unwrap(type)), real, imag));
+}
+
+MlirAttribute mlirComplexAttrDoubleGetChecked(MlirLocation loc, MlirType type,
+                                              double real, double imag) {
+  return wrap(complex::NumberAttr::getChecked(
+      unwrap(loc), cast<ComplexType>(unwrap(type)), real, imag));
+}
+
+double mlirComplexAttrGetRealDouble(MlirAttribute attr) {
+  return llvm::cast<complex::NumberAttr>(unwrap(attr)).getRealAsDouble();
+}
+
+double mlirComplexAttrGetImagDouble(MlirAttribute attr) {
+  return llvm::cast<complex::NumberAttr>(unwrap(attr)).getImagAsDouble();
+}
+
+MlirTypeID mlirComplexAttrGetTypeID(void) {
+  return wrap(complex::NumberAttr::getTypeID());
+}
+

``````````

</details>


https://github.com/llvm/llvm-project/pull/173228