[Mlir-commits] [mlir] [MLIR][GPU] Support grid constant, byval, byref on gpu.func (PR #172037)

[Asher Mancinelli]

================
@@ -369,7 +370,10 @@ GPUFuncOpLowering::matchAndRewrite(gpu::GPUFuncOp gpuFuncOp, OpAdaptor adaptor,
     }
 
     if (lowersToPointer) {
+      copyPointerAttribute(mlir::NVVM::NVVMDialect::getGridConstantAttrName());
----------------
ashermancinelli wrote:

> The claim is that if the type doesn't change - so llvm.ptr, i32, etc. - can get their argument attributes copied unconditionally.

This is what I did in 7e36123, but I don't want to rely on kludges. I'm happy to follow this up with the "bulletproof" fix, once I better understand what that should look like. Thanks for your reviews!

https://github.com/llvm/llvm-project/pull/172037