[Mlir-commits] [mlir] [MLIR][GPU] Support grid constant, byval, byref on gpu.func (PR #172037)

[Asher Mancinelli]

================
@@ -369,7 +370,10 @@ GPUFuncOpLowering::matchAndRewrite(gpu::GPUFuncOp gpuFuncOp, OpAdaptor adaptor,
     }
 
     if (lowersToPointer) {
+      copyPointerAttribute(mlir::NVVM::NVVMDialect::getGridConstantAttrName());
----------------
ashermancinelli wrote:

Okay, thanks. 

I wouldn't mind following this pr up with a better fix though--do you have a suggestion for how the proper grid constant attribute would be spelled? I can see how we would attach traits to byval and byref since they are proper attributes, but grid_constant is just a UnitAttr.

https://github.com/llvm/llvm-project/pull/172037