[Mlir-commits] [mlir] [MLIR][GPU] Support grid constant, byval, byref on gpu.func (PR #172037)

[Asher Mancinelli]

================
@@ -369,7 +370,10 @@ GPUFuncOpLowering::matchAndRewrite(gpu::GPUFuncOp gpuFuncOp, OpAdaptor adaptor,
     }
 
     if (lowersToPointer) {
+      copyPointerAttribute(mlir::NVVM::NVVMDialect::getGridConstantAttrName());
----------------
ashermancinelli wrote:

Ok - I'm only thinking of copying the attrs over unconditionally when the type is llvm.ptr on the gpu.func, meaning the argument type is not changed during lowering. Is that what you are saying you're opposed to?

https://github.com/llvm/llvm-project/pull/172037