[Mlir-commits] [mlir] [mlir] Compose expand of collapse to cast (PR #172864)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Thu Dec 18 06:53:24 PST 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- mlir/include/mlir/Dialect/Utils/ReshapeOpsUtils.h mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp mlir/lib/Dialect/Tensor/IR/TensorOps.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/mlir/include/mlir/Dialect/Utils/ReshapeOpsUtils.h b/mlir/include/mlir/Dialect/Utils/ReshapeOpsUtils.h
index dea28268b..64c125024 100644
--- a/mlir/include/mlir/Dialect/Utils/ReshapeOpsUtils.h
+++ b/mlir/include/mlir/Dialect/Utils/ReshapeOpsUtils.h
@@ -372,7 +372,7 @@ struct ComposeExpandOfCollapseOp : public OpRewritePattern<ExpandOpTy> {
hasNonIdentityLayout(collapseOp.getResult().getType())) {
if (CastOpTy::areCastCompatible(srcType, resultType)) {
rewriter.replaceOpWithNewOp<CastOpTy>(expandOp, resultType,
- collapseOp.getSrc());
+ collapseOp.getSrc());
return success();
}
return failure();
diff --git a/mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp b/mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
index ec9fce057..2eabfa972 100644
--- a/mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
+++ b/mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
@@ -2511,7 +2511,8 @@ void ExpandShapeOp::getCanonicalizationPatterns(RewritePatternSet &results,
MLIRContext *context) {
results.add<
ComposeReassociativeReshapeOps<ExpandShapeOp, ReshapeOpKind::kExpand>,
- ComposeExpandOfCollapseOp<ExpandShapeOp, CollapseShapeOp, CastOp>>(context);
+ ComposeExpandOfCollapseOp<ExpandShapeOp, CollapseShapeOp, CastOp>>(
+ context);
}
FailureOr<std::optional<SmallVector<Value>>>
``````````
</details>
https://github.com/llvm/llvm-project/pull/172864
More information about the Mlir-commits
mailing list