[Mlir-commits] [mlir] Enable printing newlines and indents in attribute and type printers (PR #87948)

[Jacques Pienaar]

jpienaar wrote:

We had a few back and forths, and discussed. There is still open a question on whether there should be contextually shown. Also discussed if its better to have policies wrt to size etc - this fit into "flexibility for attribute printers but instead of explicit restriction provide more guidance for IR design" part. We didn't come up with something very satisfactory for all parts. But this is also something that we can revise and refine. Given its useful, given the existing alternative folks can already use would produce something worse, we've gone with:
- Allow with caveat that the exact output format could change (nothing decided change wise, just not fixed)
- Upstream, usage disallowed/very limited until more experience gained
- Document that the flexibility is not an endorsement and good guidelines not in place yet

With that we are fine proceeding here and refining at later stage.

https://github.com/llvm/llvm-project/pull/87948