[Mlir-commits] [mlir] [mlir] Use getAttr to replace getInherentAttr in the test-symbol-uses pass (PR #172675)

[lonely eagle]

================
@@ -59,7 +59,7 @@ struct SymbolUsesPass
               symbolUse.getUser()->getParentOp(), symbolUse.getSymbolRef())) {
         symbolUse.getUser()->emitRemark()
             << "found use of symbol : " << symbolUse.getSymbolRef() << " : "
-            << *symbol->getInherentAttr(SymbolTable::getSymbolAttrName());
+            << symbol->getAttr(SymbolTable::getSymbolAttrName());
----------------
linuxlonelyeagle wrote:

> So can we update:
> 
> ```
> WalkResult operateOnSymbol(Operation *symbol,
> ```
> 
> to be:
> 
> ```
> WalkResult operateOnSymbol(SymbolOpInterface symbol,
> ```
> 
> and rely on the interface instead?

I think there is something a bit incorrect, I don't know if I misunderstood. Accessing "launch_func" is done through walk "gpu. func". The walk function does not directly access " launch_func "

https://github.com/llvm/llvm-project/pull/172675