[Mlir-commits] [mlir] [mlir] Use getAttr to replace getInherentAttr in the test-symbol-uses pass (PR #172675)

Mehdi Amini llvmlistbot at llvm.org
Wed Dec 17 07:19:21 PST 2025


================
@@ -59,7 +59,7 @@ struct SymbolUsesPass
               symbolUse.getUser()->getParentOp(), symbolUse.getSymbolRef())) {
         symbolUse.getUser()->emitRemark()
             << "found use of symbol : " << symbolUse.getSymbolRef() << " : "
-            << *symbol->getInherentAttr(SymbolTable::getSymbolAttrName());
+            << symbol->getAttr(SymbolTable::getSymbolAttrName());
----------------
joker-eph wrote:

So can we update:
```
WalkResult operateOnSymbol(Operation *symbol,
```
to be:

```
WalkResult operateOnSymbol(SymbolOpInterface symbol,
```

and rely on the interface instead?

https://github.com/llvm/llvm-project/pull/172675


More information about the Mlir-commits mailing list