[Mlir-commits] [mlir] [MLIR][Quant] Add DialectInlinerInterface to QuantDialect (PR #172509)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir-quant

@llvm/pr-subscribers-mlir

Author: Jonas Rickert (jorickert)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/172509.diff


2 Files Affected:

- (modified) mlir/lib/Dialect/Quant/IR/QuantOps.cpp (+10) 
- (added) mlir/test/Dialect/Quant/inlining.mlir (+47) 


``````````diff
diff --git a/mlir/lib/Dialect/Quant/IR/QuantOps.cpp b/mlir/lib/Dialect/Quant/IR/QuantOps.cpp
index e23a0d6aba825..060707437334e 100644
--- a/mlir/lib/Dialect/Quant/IR/QuantOps.cpp
+++ b/mlir/lib/Dialect/Quant/IR/QuantOps.cpp
@@ -14,6 +14,7 @@
 #include "mlir/IR/BuiltinTypes.h"
 #include "mlir/IR/PatternMatch.h"
 #include "mlir/IR/TypeUtilities.h"
+#include "mlir/Transforms/InliningUtils.h"
 
 #include "mlir/Dialect/Quant/IR/QuantOpsDialect.cpp.inc"
 
@@ -183,6 +184,14 @@ LogicalResult verifyQuantizationOp(Operation *op, QuantizedType quantizedType,
   return success();
 }
 
+struct QuantInlinerInterface : public DialectInlinerInterface {
+  using DialectInlinerInterface::DialectInlinerInterface;
+  /// All quant dialect ops can be inlined.
+  bool isLegalToInline(Operation *, Region *, bool, IRMapping &) const final {
+    return true;
+  }
+};
+
 } // namespace
 
 //===----------------------------------------------------------------------===//
@@ -197,6 +206,7 @@ void QuantDialect::initialize() {
 #include "mlir/Dialect/Quant/IR/QuantOps.cpp.inc"
       >();
   detail::addBytecodeInterface(this);
+  addInterfaces<QuantInlinerInterface>();
 }
 
 //===----------------------------------------------------------------------===//
diff --git a/mlir/test/Dialect/Quant/inlining.mlir b/mlir/test/Dialect/Quant/inlining.mlir
new file mode 100644
index 0000000000000..6cb06efc8b633
--- /dev/null
+++ b/mlir/test/Dialect/Quant/inlining.mlir
@@ -0,0 +1,47 @@
+// RUN: mlir-opt %s -inline | FileCheck %s
+
+!qalias = !quant.uniform<i8:f32, 2.0:10>
+
+func.func @inner_dcast_inlinable(%arg0: !qalias) -> f32 {
+  %0 = quant.dcast %arg0 : !qalias to f32
+  return %0 : f32
+}
+
+//  CHECK-LABEL: func.func @test_inline_dcast(
+//  CHECK-NOT:    func.call
+//  CHECK-NEXT:   quant.dcast
+func.func @test_inline_dcast(%v: !qalias) -> f32 {
+  %0 = call @inner_dcast_inlinable(%v) : (!qalias) -> f32
+  return %0 : f32
+}
+
+
+
+func.func @inner_qcast_inlinable(%v: f32) -> !qalias {
+  %1 = quant.qcast %v : f32 to !qalias
+  return %1 : !qalias
+}
+
+//  CHECK-LABEL: func.func @test_inline_qcast(
+//  CHECK-NOT:    func.call
+//  CHECK-NEXT:   quant.qcast
+func.func @test_inline_qcast(%v: f32) -> !qalias {
+  %0 = call @inner_qcast_inlinable(%v) : (f32) -> !qalias
+  return %0 : !qalias
+}
+
+func.func @inner_scast_inlinable(%v: i8) -> !qalias {
+  %1 = quant.scast %v : i8 to !qalias
+  return %1 : !qalias
+}
+
+//  CHECK-LABEL: func.func @test_inline_scast(
+//  CHECK-NOT:    func.call
+//  CHECK-NEXT:   quant.scast
+func.func @test_inline_scast(%v: i8) -> !qalias {
+  %0 = call @inner_scast_inlinable(%v) : (i8) -> !qalias
+  return %0 : !qalias
+}
+
+
+

``````````

</details>


https://github.com/llvm/llvm-project/pull/172509