[Mlir-commits] [mlir] Reland [mlir][gpu] Use `SmallString`, `FailureOr` and `StringRef` in `module-to-binary` infra (NFC) (PR #172390)

[Ivan Butygin]

Hardcode84 wrote:

> Could we update the parser as a follow-up?

Do you mean `MCAsmParser`? If I remove check from the memory buffer it fails eventually on this assert https://github.com/llvm/llvm-project/blob/8603552133c832080dac6de2460ebf5d2a1f1be0/llvm/lib/MC/MCParser/AsmLexer.cpp#L124

Not sure If I want to go this rabbit hole.

https://github.com/llvm/llvm-project/pull/172390