[Mlir-commits] [mlir] [mlir][gpu] Expose some utility functions from `gpu-to-binary` infra (PR #172205)

[Fabian Mora]

================
@@ -98,11 +105,6 @@ class ModuleToObject {
   /// Optimize the module.
   virtual LogicalResult optimizeModule(llvm::Module &module, int optL);
 
-  /// Utility function for translating to ISA, returns `std::nullopt` on
-  /// failure.
-  static std::optional<std::string>
-  translateToISA(llvm::Module &llvmModule, llvm::TargetMachine &targetMachine);
-
----------------
fabianmcg wrote:

That's fine, you can just make it public. I think it's better for it to remain scoped under the class to avoid further pollution of `mlir::LLVM`. Otherwise, I'd suggest introducing a new namespace.

https://github.com/llvm/llvm-project/pull/172205