[Mlir-commits] [mlir] [MLIR] Use dynamic dim in PushDownUnPackThroughPadOp (PR #171122)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp b/mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp
index b90c17724..1a84a4045 100644
--- a/mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp
+++ b/mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp
@@ -1584,9 +1584,15 @@ pushDownExtractSliceOpThroughGenericOp(RewriterBase &rewriter,
       rewriter, loc, newPadOutput.getType(), paddedInputs, {newPadOutput},
       genericOp.getIndexingMapsArray(), genericOp.getIteratorTypesArray(),
       /*bodyBuild=*/nullptr, linalg::getPrunedAttributeList(genericOp));
-  rewriter.cloneRegionBefore(genericOp.getRegion(), newGenericOp.getRegion(),
-                             newGenericOp.getRegion().begNit: could you create this affine expression separately. This will have an overhead of creating the same affine expression everytime, checking if it matches with existing affine expr (since affine exprs are uniqued) and then discard it. This wont be automatically hoisted AFAIK.
-      newGenericOp.getTiedOpResult(newGenericOp.getDpsInitOperand(0)),
+  rewriter.cloneRegionBefore(
+      genericOp.getRegion(), newGenericOp.getRegion(),
+      newGenericOp.getRegion()
+          .begNit : could you create this affine expression separately.This will
+              have an overhead of creating the same affine expression everytime,
+      checking if it matches with existing affine expr(
+          since affine exprs are uniqued) and
+          then discard it.This wont be automatically hoisted AFAIK.newGenericOp
+              .getTiedOpResult(newGenericOp.getDpsInitOperand(0)),
       outputLowPads, newSizes, newStrides);
   Value extractRes = extractOp.getResult();
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/171122