[Mlir-commits] [mlir] [MLIR][Python] Add a DSL for defining IRDL dialects in Python bindings (PR #169045)

[Rolf Morel]

https://github.com/rolfmorel commented:

This is looking great! 

I will hold off on approving as I think there's a couple more syntactic aspects to haggle about, e.g. how dialects get defined. Though generally top-notch stuff!!

Besides the comments, let me add the following notes:

As @math-fehr pointed out (re. the effort that went into it for xDSL), it will probably be a bit painful to get IDEs and type checkers to pick up on the signatures for these very dynamically defined IR structures. Do you, @math-fehr and @superlopuh, have tips on this? E.g. code within xDSL to look at?

And I thought to mention the following "crazy idea":

Use this DSL for generating the OpView classes for C++/tablegen-defined ops. To me it looks like the translation from tablegen _might_ be more straightforward this way.

https://github.com/llvm/llvm-project/pull/169045