[Mlir-commits] [mlir] [mlir][Linalg] Allow more control in drop unit dims (PR #171796)

[llvmlistbot at llvm.org]

================
@@ -63,6 +122,10 @@ struct TestLinalgDropUnitDims
 
     for (auto genericOp : genericOps) {
       rewriter.setInsertionPoint(genericOp);
+      if (collapseEncoded) {
+        (void)dropOutermostUnitDimsWithEncoding(rewriter, genericOp);
----------------
MaheshRavishankar wrote:

It might be better to drop the `void`. All the existing tests shouldnt return `failure()` here. So I dont think we need to ignore it. Worth a try and seeing. If you see issues, then we can defer to a follow up cause, again this is the current state and we can split the work of fixing this in a future PR.

https://github.com/llvm/llvm-project/pull/171796