[Mlir-commits] [mlir] [mlir][tosa] Add pass to assign static input shape to TOSA functions (PR #171156)

[Sayan Saha]

================
@@ -198,4 +198,26 @@ def TosaNarrowI64ToI32Pass : Pass<"tosa-narrow-i64-to-i32", "func::FuncOp"> {
   ];
 }
 
+def TosaInputShape : Pass<"tosa-experimental-input-shape", "func::FuncOp"> {
----------------
sahas3 wrote:

> Other than testing/experimentation, we weren't sure how useful this pass would be in practise. Marking it as "experimental" is an attempt to indicate that the pass might change or be removed in the future.

I was just curious, I hadn't seen use of `experimental` in a pass name before. I understand the motivation that mentioning `experimental` indicates that the pass can be removed and it seems fine to me. 

In terms of usefulness, we have a similar pass internally that allows specifying static dims for dynamic dims for input operands to a function. We also allow a mix of static and dynamic as long as a dynamic dims is not specified for an input dim that's actually static.

https://github.com/llvm/llvm-project/pull/171156