[Mlir-commits] [mlir] 58cb487 - Revert "[mlir] Fix '-Wtemplate-id-cdtor'. NFC"

Krzysztof Parzyszek llvmlistbot at llvm.org
Mon Dec 8 08:49:14 PST 2025


Author: Krzysztof Parzyszek
Date: 2025-12-08T10:48:53-06:00
New Revision: 58cb4873f965271956ca32f0a9dfdad20012a6c5

URL: https://github.com/llvm/llvm-project/commit/58cb4873f965271956ca32f0a9dfdad20012a6c5
DIFF: https://github.com/llvm/llvm-project/commit/58cb4873f965271956ca32f0a9dfdad20012a6c5.diff

LOG: Revert "[mlir] Fix '-Wtemplate-id-cdtor'. NFC"

This reverts commit fccb65ef8f0faf40ca5dfaaa0ef70821f8843821.

It breaks pre-merge CI:
```
2025-12-08T16:35:11.7239054Z /home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/lib/Pass/PassRegistry.cpp:439:37: error: ISO C++ requires the name after '::~' to be found in the same scope as the name before '::~' [-Werror,-Wdtor-name]
2025-12-08T16:35:11.7240458Z   439 | llvm::cl::OptionValue<OpPassManager>::~OptionValue() = default;
2025-12-08T16:35:11.7241014Z       | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
2025-12-08T16:35:11.7241494Z       |                                     ::OptionValue
2025-12-08T16:35:11.7241903Z 1 error generated.
```

Added: 
    

Modified: 
    mlir/lib/Pass/PassRegistry.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Pass/PassRegistry.cpp b/mlir/lib/Pass/PassRegistry.cpp
index 9a240d51c98bc..bc766d43e1109 100644
--- a/mlir/lib/Pass/PassRegistry.cpp
+++ b/mlir/lib/Pass/PassRegistry.cpp
@@ -436,7 +436,7 @@ llvm::cl::OptionValue<OpPassManager>::operator=(
   return *this;
 }
 
-llvm::cl::OptionValue<OpPassManager>::~OptionValue() = default;
+llvm::cl::OptionValue<OpPassManager>::~OptionValue<OpPassManager>() = default;
 
 void llvm::cl::OptionValue<OpPassManager>::setValue(
     const OpPassManager &newValue) {


        


More information about the Mlir-commits mailing list