[Mlir-commits] [mlir] [mlir][CMake] enable disabling MLIR_ENABLE_EXECUTION_ENGINE (PR #171060)

[Maksim Levental]

makslevental wrote:

> Can we instead improve the logic to detect that this is an unsupported target, and disable the execution engine (with a warning maybe), that would be more in line with the existing logic.

It's a top-level CMake variable - I don't understand what the issue is with giving people the choice to disable it? I don't see the difference between that variable and these which are fully user settable https://github.com/llvm/llvm-project/blob/ebdb903c105deefc2598181497f0aebcf65f4b01/mlir/CMakeLists.txt#L148-L156

> Someone hitting that linking error you mentioned wouldn't have a clue about what to do to make their build work otherwise.

That linking error is a `wasm-ld` isssue - it turned out to be a red-herring. But my point about unnecessary compile cost on `wasm32` (or anywhere else people don't want/use ExecutionEngine) still stands.

https://github.com/llvm/llvm-project/pull/171060