[Mlir-commits] [mlir] [mlir][amdgpu] Add workgroup_mask to MakeDmaDescriptorOp (PR #171103)

[Jakub Kuderski]

================
@@ -768,6 +768,11 @@ LogicalResult MakeDmaDescriptorOp::verify() {
       return emitOpError("atomic barrier address must be in LDS.");
   }
 
+  if (getEarlyTimeout() != nullptr && getWorkgroupMask() == nullptr) {
+    return emitOpError(
+        "early timeout does not apply when workgroup_mask is not set.");
+  }
+
----------------
kuhar wrote:

also we generally don't compare against nullptr in mlir; just `if (getEarlyTimeout() && getWorkgroupMask())`

https://github.com/llvm/llvm-project/pull/171103