[Mlir-commits] [mlir] [mlir][amdgpu] Add workgroup_mask to MakeDmaDescriptorOp (PR #171103)

[Erick Ochoa Lopez]

================
@@ -768,6 +768,11 @@ LogicalResult MakeDmaDescriptorOp::verify() {
       return emitOpError("atomic barrier address must be in LDS.");
   }
 
+  if (getEarlyTimeout() != nullptr && getWorkgroupMask() == nullptr) {
+    return emitOpError(
+        "early timeout does not apply when workgroup_mask is not set.");
+  }
+
----------------
amd-eochoalo wrote:

Really small nits

```suggestion
  if (getEarlyTimeout() != nullptr && getWorkgroupMask() == nullptr)
    return emitOpError(
        "early timeout does not apply when workgroup_mask is not set.");
```

It would also be nice to have this tested in invalid.mlir. But I can add it in the follow up PRs.

https://github.com/llvm/llvm-project/pull/171103