[Mlir-commits] [mlir] [MLIR][ExecutionEngine] Don't create a `_mlir_` wrapper function for internal linkage (PR #171115)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Mehdi Amini (joker-eph)

<details>
<summary>Changes</summary>

This is somehow NFC, we were creating wrapper for interal functions, which are de-facto not callable.

---
Full diff: https://github.com/llvm/llvm-project/pull/171115.diff


1 Files Affected:

- (modified) mlir/lib/ExecutionEngine/ExecutionEngine.cpp (+2-4) 


``````````diff
diff --git a/mlir/lib/ExecutionEngine/ExecutionEngine.cpp b/mlir/lib/ExecutionEngine/ExecutionEngine.cpp
index 2255633c746b3..287c52a262c11 100644
--- a/mlir/lib/ExecutionEngine/ExecutionEngine.cpp
+++ b/mlir/lib/ExecutionEngine/ExecutionEngine.cpp
@@ -146,12 +146,10 @@ static void packFunctionArguments(Module *module) {
   llvm::IRBuilder<> builder(ctx);
   DenseSet<llvm::Function *> interfaceFunctions;
   for (auto &func : module->getFunctionList()) {
-    if (func.isDeclaration()) {
+    if (func.isDeclaration() || func.hasLocalLinkage())
       continue;
-    }
-    if (interfaceFunctions.count(&func)) {
+    if (interfaceFunctions.count(&func))
       continue;
-    }
 
     // Given a function `foo(<...>)`, define the interface function
     // `mlir_foo(i8**)`.

``````````

</details>


https://github.com/llvm/llvm-project/pull/171115