[Mlir-commits] [mlir] [mlir][bufferization] Enable moving dependent values in eliminate-empty-tensors (PR #169718)

[Matthias Springer]

================
@@ -84,7 +84,8 @@ LogicalResult moveOperationDependencies(RewriterBase &rewriter, Operation *op,
 /// Move definitions of `values` before an insertion point. Current support is
 /// only for movement of definitions within the same basic block. Note that this
 /// is an all-or-nothing approach. Either definitions of all values are moved
-/// before insertion point, or none of them are.
+/// before insertion point, or none of them are. Any side-effecting operations
+/// in the producer chain pessimistically blocks movement.
----------------
matthias-springer wrote:

Can you also update the documentation here?
```
def TestMoveValueDefns :
    Op<Transform_Dialect, "test.move_value_defns",
        [FunctionalStyleTransformOpTrait, MemoryEffectsOpInterface,
         DeclareOpInterfaceMethods<TransformOpInterface>,
         ReportTrackingListenerFailuresOpTrait]> {
  let description = [{
    Moves all dependencies of on operation before another operation.
  }];
```


https://github.com/llvm/llvm-project/pull/169718