[Mlir-commits] [mlir] [acc] Add an API to make private recipes out of firstprivate recipes (PR #170588)

[llvmlistbot at llvm.org]

https://github.com/jeanPerier approved this pull request.

This looks good to me.

One thing to point is that this assumes that the language lowering generates the same init region for a private and a firstprivate, and there is one case where I think this may not always be true which is the case of types with default initialization.
When generating a private recipe, the language lowering will generate the default initialization, while when making a firstprivate recipe, it could skip that part in the init since the the value will be copy constructed in the the copy region.

Do you foresee this helper to be used for C++ classes/Fortran derived types? If so this case may need to be clarified, otherwise this is fine (it would be great to have an assert, but I am not sure how you could add that in the interface implementation without language support).

https://github.com/llvm/llvm-project/pull/170588