[Mlir-commits] [mlir] [mlir][Linalg] Allow more control in drop unit dims (PR #170104)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Thanks for contributing!

What should happen if tensors use different encodings? Also:

> The extended struct allows users to specify functions to:
> 
> * Calculate the shape and new index map of operands, which also allows to control which operands get their unit extent dimension dropped.
> * How the operands are collapsed
> * How the result is expanded to the original shape

That's 3 things, but only one new test is added.

Btw, would object to reducing the density of lambdas? Basically, I see quite a few nested functions that I find hard to parse and which, IMHO, should be documented. Perhaps this could be improved with comments alone 🤷🏻 

https://github.com/llvm/llvm-project/pull/170104