[Mlir-commits] [mlir] [mlir][gpu] Propagate errors from `ModuleToObject` callbacks (PR #170134)

[Ivan Butygin]

Hardcode84 wrote:

> There is a diagnostic issue here: the callbacks don't have any information needed to diagnose (no MLIRContext, no operation to attach the diagnostic to...).

I can add source op arg to all the callbacks.

> The use-case for this looks quite hand-wavy to me to justify adding more complexity to correctly handle all this though.

The one potential use case I considered is something similar to Triton `TRITON_OVERRIDE_DIR` https://github.com/triton-lang/triton/blob/main/README.md#tips-for-hacking, where you can override an IR from file on specific step for debugging. You need to properly propagate fs/parsing errors in this case obviously.

https://github.com/llvm/llvm-project/pull/170134