[Mlir-commits] [mlir] [MLIR] Forward generated OpTy::create arguments (PR #170012)

[Jakub Kuderski]

================
@@ -235,14 +235,14 @@ def NS_FOp : NS_Op<"op_with_all_types_constraint",
 
 // DEFS: FOp FOp::create(::mlir::OpBuilder &builder, ::mlir::Location location, ::mlir::Value a) {
 // DEFS:   ::mlir::OperationState __state__(location, getOperationName());
-// DEFS:   build(builder, __state__, a);
+// DEFS:   build(builder, __state__, static_cast<decltype(a)>(a));
----------------
kuhar wrote:

I think move could have unexpected consequences on values passed by (non-const) reference -- IMO making arguments explicitly rvalue references and forwarding is less surprising 

https://github.com/llvm/llvm-project/pull/170012