[Mlir-commits] [mlir] [mlir][gpu] Propagate errors from `ModuleToObject` callbacks (PR #170134)

[Fabian Mora]

https://github.com/fabianmcg commented:

In general LGTM, the only change I would make is:
- Passing a Location as well to the callbacks
- Let the callback handle the error message, so no `getOperation().emitError() << "ISACallback failed.";`

I'd argue that this is already a wanted change, as I could have a custom out of tree LLVM pass running at any of the LLVM callback levels that could fail.

https://github.com/llvm/llvm-project/pull/170134