[Mlir-commits] [mlir] [mlir][ptr] Add load and store ops. (PR #156093)

Mehdi Amini llvmlistbot at llvm.org
Sun Aug 31 06:35:26 PDT 2025


================
@@ -773,9 +773,10 @@ class OptionalProp<Property p, bit canDelegateParsing = 1>
   }];
   let writeToMlirBytecode = [{
     $_writer.writeOwnedBool($_storage.has_value());
-    if (!$_storage.has_value())
-      return;
-  }] # !subst("$_storage", "(*($_storage))", p.writeToMlirBytecode);
+    if ($_storage.has_value()) {
+      }] # !subst("$_storage", "(*($_storage))", p.writeToMlirBytecode) # [{
----------------
joker-eph wrote:

As I read it (and copilot as well), your new code looks instead:

```
 if ($_storage.has_value()) {
 }
writer.writeVarInt((*(propStorage)));
```



https://github.com/llvm/llvm-project/pull/156093


More information about the Mlir-commits mailing list