[Mlir-commits] [flang] [llvm] [mlir] [flang][OpenMP] Enable tiling (PR #143715)

[Sergio Afonso]

https://github.com/skatrak commented:

Thank you for the clarifications and updates Jan, I have just one blocking comment and some minor nits, but overall this looks almost ready to me.

Currently, there is a comment in `initTargetRuntimeAttrs` stating that it calculates the trip count by multiplying the trip counts of every collapsed canonical loop. I think that comment should be updated to basically just say that it's calculated by multiplying the trip counts of all nested loops represented by the op. This is just so it doesn't become confusing after the changes to `omp.loop_nest`.

https://github.com/llvm/llvm-project/pull/143715