[Mlir-commits] [mlir] [mlir][emitc] Isolate expressions from above (PR #155641)

[Marius Brehler]

marbre wrote:

> > What do you think about making syntax more function like?
> > For example:
> > ```mlir
> > emitc.expression(%a : i1, %b : i1) -> i1 {
> > } 
> > ```
> 
> The `func.func` syntax it's also a possibility and I'm indeed not sure what works best. My intuition was that an uncluttered list of args is more easy to read, simiar to `func.call`, `emitc.call` and `emitc.opaque_call` (although perhaps the current syntax needs `()` around the args to be fully compliant with them), but I don't feel very strongly about it. @marbre, @jacquesguan, any preference?

No super strong feelings on my side either but maybe a light preference to keep as is.
```mlir
expression %a, %b : (i1, i1) -> i1 {..}
```
is closer to other operations while `call` and `call_opaque` are a bit different due to having a callee. AS expressions don't have a callee or symbol name, maybe we keep as is?


https://github.com/llvm/llvm-project/pull/155641