[Mlir-commits] [llvm] [mlir] [LLVM][MLIR] Move LSP server support library from MLIR into LLVM (PR #155572)

[Mehdi Amini]

Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/155572 at github.com>


================

----------------
joker-eph wrote:

I just tried, with the current version of the PR:

```
$ ninja MLIRLspServerSupportLib
[431/432] Linking CXX shared library lib/libMLIRLspServerSupportLib.so.22.0git
FAILED: lib/libMLIRLspServerSupportLib.so.22.0git 
: && /home/mamini/bin/clang++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Werror=mismatched-tags -Werror=global-constructors -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete -fuse-ld=lld -Wl,--color-diagnostics   -Wl,--gc-sections -shared -Wl,-soname,libMLIRLspServerSupportLib.so.22.0git -o lib/libMLIRLspServerSupportLib.so.22.0git tools/mlir/lib/Tools/lsp-server-support/CMakeFiles/obj.MLIRLspServerSupportLib.dir/CompilationDatabase.cpp.o tools/mlir/lib/Tools/lsp-server-support/CMakeFiles/obj.MLIRLspServerSupportLib.dir/SourceMgrUtils.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/mamini/projects/llvm-project/build/lib:"  lib/libMLIRSupport.so.22.0git  lib/libLLVMSupport.so.22.0git  -Wl,-rpath-link,/home/mamini/projects/llvm-project/build/lib && :
ld.lld: error: undefined symbol: llvm::lsp::URIForFile::fromFile(llvm::StringRef, llvm::StringRef)
>>> referenced by CompilationDatabase.cpp
>>>               tools/mlir/lib/Tools/lsp-server-support/CMakeFiles/obj.MLIRLspServerSupportLib.dir/CompilationDatabase.cpp.o:(mlir::lsp::CompilationDatabase::loadDatabase(llvm::StringRef))
>>> referenced by SourceMgrUtils.cpp
>>>               tools/mlir/lib/Tools/lsp-server-support/CMakeFiles/obj.MLIRLspServerSupportLib.dir/SourceMgrUtils.cpp.o:(mlir::lsp::gatherIncludeFiles(llvm::SourceMgr&, llvm::SmallVectorImpl<mlir::lsp::SourceMgrInclude>&))

ld.lld: error: undefined symbol: llvm::lsp::Logger::log(llvm::lsp::Logger::Level, char const*, llvm::formatv_object_base const&)
>>> referenced by CompilationDatabase.cpp
>>>               tools/mlir/lib/Tools/lsp-server-support/CMakeFiles/obj.MLIRLspServerSupportLib.dir/CompilationDatabase.cpp.o:(mlir::lsp::CompilationDatabase::loadDatabase(llvm::StringRef))
>>> referenced by CompilationDatabase.cpp
>>>               tools/mlir/lib/Tools/lsp-server-support/CMakeFiles/obj.MLIRLspServerSupportLib.dir/CompilationDatabase.cpp.o:(mlir::lsp::CompilationDatabase::loadDatabase(llvm::StringRef))
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
```

https://github.com/llvm/llvm-project/pull/155572