[Mlir-commits] [mlir] [MLIR][SideEffects][MemoryEffects] Modified LICM to be more aggressive when checking movability of ops with MemWrite effects (PR #155344)

[Mehdi Amini]

================
@@ -471,6 +493,35 @@ bool wouldOpBeTriviallyDead(Operation *op);
 /// conditions are satisfied.
 bool isMemoryEffectFree(Operation *op);
 
+/// Returns true if the given operation has conflict-free write effects
+///
+/// An operation is conflict free:
+/// (1) Parent is a loop with the LoopLikeOpInterface
----------------
joker-eph wrote:

IMO: this is far too specific of a method for 1) this file and 2) the API name.
I would keep this somewhere related to loops (or in the LICM implementation for now)

https://github.com/llvm/llvm-project/pull/155344