[Mlir-commits] [llvm] [mlir] [LLVM][MLIR] Move LSP server support library from MLIR into LLVM (PR #155572)

[Mehdi Amini]

Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>,
Albert =?utf-8?q?Havliček?= <ahavlicek at azul.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/155572 at github.com>


================
@@ -0,0 +1,17 @@
+add_llvm_library(LLVMSupportLSP STATIC
+  Protocol.cpp
+  Transport.cpp
+  Logging.cpp
+)
+
+target_include_directories(LLVMSupportLSP
+  PUBLIC
+    $<BUILD_INTERFACE:${LLVM_MAIN_INCLUDE_DIR}>
+    $<BUILD_INTERFACE:${LLVM_LIBRARY_DIR}/Support/LSP>
+    $<INSTALL_INTERFACE:include>   # for installation
+)
+
+target_link_libraries(LLVMSupportLSP
+  PUBLIC
+    LLVMSupport
+)
----------------
joker-eph wrote:

I'm confused by the setup: you have a library here but you **also** include all the objects in LLVMSupport, while you depend on the support library here?

https://github.com/llvm/llvm-project/pull/155572