[Mlir-commits] [mlir] [mlir][debug] Convert DbgIntrOp to DebugRecords directly. (PR #154926)

[Tobias Gysi]

================
@@ -673,22 +673,6 @@ def LLVM_CoroPromiseOp : LLVM_IntrOp<"coro.promise", [], [], [], 1> {
 
 class LLVM_DbgIntrOp<string name, string argName, list<Trait> traits = []>
----------------
gysit wrote:

You are correct that MLIR does not have the concept of an intrinsic. However, LLVM dialect still models intrinsics, using operations, and it doesn't have the equivalent of debug records. Ideally, a debug record would not be an MLIR operation, but some sort of Location attribute attached to an operation. Unfortunately, MLIR Locations cannot depend on values which would be necessary for debug records if I understand them correctly. 

TD;LR we will need to come up with a modeling for debug records. Ideally, this would be done with MLIR's Location infrastructure, but I fear we will have to stick to operations. 

https://github.com/llvm/llvm-project/pull/154926