[Mlir-commits] [mlir] [mlir][memref] Alias attributes for memref dialect (PR #154991)

[Erick Ochoa Lopez]

================
@@ -0,0 +1,34 @@
+// RUN: mlir-opt --convert-memref-alias-attributes-to-llvm %s | FileCheck %s
+
+#alias_scope1 = #memref.alias_scope<id = distinct[1]<>, description = "scope">
----------------
amd-eochoalo wrote:

Once the discussion in the RFC is settled, could you add a comment here stating the importance of this test. I think this is a really good test and important since it shows a difference between LLVM IR's alias scope which is a tuple pointing to a domain scope, and MLIR which is a single attribute and uses the closest parent of `memref.alias_domain_scope` type as the second element of the LLVM IR's alias scope tuple.

Maybe another good test would be to have nested `memref.alias_domain_scope` to show that only the closest ancestor is used.

https://github.com/llvm/llvm-project/pull/154991