[Mlir-commits] [mlir] [MLIR][NVVM] Update TMA Store Op (PR #155435)

[Durgadoss R]

================
@@ -2353,6 +2353,20 @@ def TMALoadModeAttr : EnumAttr<NVVM_Dialect, TMALoadMode, "tma_load_mode"> {
   let assemblyFormat = "`<` $value `>`";
 }
 
+// List of modes supported for TMA Store and Reduction Ops
+def TMAStoreModeTile   : I32EnumAttrCase<"TILE", 0, "tile">;
+def TMAStoreModeIm2Col : I32EnumAttrCase<"IM2COL", 1, "im2col">;
+def TMAStoreModeTileScatter4 : I32EnumAttrCase<"TILE_SCATTER4", 2, "tile_scatter4">;
----------------
durga4github wrote:

I also thought about it but went with separate ones since they are already evolving in different directions.
Load has Gather, Store has Scatter as one example.

However, we will be able to manage all TMA Ops with just these two mode attrs. (and we will have one common verifier for each set):

TMA Load, Prefetch, CTA-level Copy follow load modes.
TMA Store, TMA Store-reduce etc. follow Store modes.

https://github.com/llvm/llvm-project/pull/155435