[Mlir-commits] [mlir] [mlir][debug] Convert DbgIntrOp to DebugRecords directly. (PR #154926)

[Tobias Gysi]

https://github.com/gysit commented:

The change makes sense!

Let's try to factor out some helpers to reduce the code duplication.

The casts are probably unavoidable. If there a place where the cast could fail we may want to use dyn_cast and return failure to have a better error handling. However, it sounds like refactoring the inheritance to match LLVM will fix the critical case?

https://github.com/llvm/llvm-project/pull/154926