[Mlir-commits] [mlir] b9b3cf2 - [MLIR] Apply clang-tidy fixes for performance-unnecessary-value-param in Matrix.cpp (NFC)

Mehdi Amini llvmlistbot at llvm.org
Fri Aug 22 05:58:51 PDT 2025


Author: Mehdi Amini
Date: 2025-08-22T05:54:07-07:00
New Revision: b9b3cf28eb5cfa991edbc6e91d8e8d7835e5d762

URL: https://github.com/llvm/llvm-project/commit/b9b3cf28eb5cfa991edbc6e91d8e8d7835e5d762
DIFF: https://github.com/llvm/llvm-project/commit/b9b3cf28eb5cfa991edbc6e91d8e8d7835e5d762.diff

LOG: [MLIR] Apply clang-tidy fixes for performance-unnecessary-value-param in Matrix.cpp (NFC)

Added: 
    

Modified: 
    mlir/include/mlir/Analysis/Presburger/Matrix.h
    mlir/lib/Analysis/Presburger/Matrix.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Analysis/Presburger/Matrix.h b/mlir/include/mlir/Analysis/Presburger/Matrix.h
index 054eb7b26d06e..15069fa2a55f1 100644
--- a/mlir/include/mlir/Analysis/Presburger/Matrix.h
+++ b/mlir/include/mlir/Analysis/Presburger/Matrix.h
@@ -322,7 +322,7 @@ class FracMatrix : public Matrix<Fraction> {
   // The parameter is what [the original
   // paper](https://www.cs.cmu.edu/~avrim/451f11/lectures/lect1129_LLL.pdf)
   // calls `y`, usually 3/4.
-  void LLL(Fraction delta);
+  void LLL(const Fraction &delta);
 
   // Multiply each row of the matrix by the LCM of the denominators, thereby
   // converting it to an integer matrix.

diff  --git a/mlir/lib/Analysis/Presburger/Matrix.cpp b/mlir/lib/Analysis/Presburger/Matrix.cpp
index 9fc6205eb5ed5..55ecae33965b1 100644
--- a/mlir/lib/Analysis/Presburger/Matrix.cpp
+++ b/mlir/lib/Analysis/Presburger/Matrix.cpp
@@ -721,7 +721,7 @@ FracMatrix FracMatrix::gramSchmidt() const {
 // Otherwise, we swap b_k and b_{k-1} and decrement k.
 //
 // We repeat this until k = n and return.
-void FracMatrix::LLL(Fraction delta) {
+void FracMatrix::LLL(const Fraction &delta) {
   DynamicAPInt nearest;
   Fraction mu;
 


        


More information about the Mlir-commits mailing list