https://github.com/SLTozer commented: Can't speak to the MLIR logic, but the DIBuilder usage LGTM (also looks like we missed a spot, leaving the debug value creation function as `insertDbgValueIntrinsic`!) - thanks for updating this! https://github.com/llvm/llvm-project/pull/154926