[Mlir-commits] [mlir] [MLIR][NFC] Speed up is valid symbol check (PR #154924)
Mehdi Amini
llvmlistbot at llvm.org
Fri Aug 22 04:28:14 PDT 2025
================
@@ -445,17 +464,11 @@ bool mlir::affine::isValidSymbol(Value value, Region *region) {
return false;
// A top-level value is a valid symbol.
- if (region && ::isTopLevelValue(value, region))
+ if (region && isTopLevelValueOrDominator(value, region))
----------------
joker-eph wrote:
```suggestion
if (region && isTopLevelValueOrAbove(value, region))
```
"dominate" is enforced by the verifier, "used from above" is the usual terminology elsewhere in the codebase.
https://github.com/llvm/llvm-project/pull/154924
More information about the Mlir-commits
mailing list