[Mlir-commits] [mlir] [MLIR][NFC] Speed up is valid symbol check (PR #154924)

[Mehdi Amini]

================
@@ -427,6 +427,25 @@ bool mlir::affine::isValidSymbol(Value value) {
   return false;
 }
 
+/// A utility function to check if a value is defined at the top level of
+/// `region` or is an argument of `region` or dominates the region.
----------------
joker-eph wrote:

Where is the "dominate" aspect checked?
As far as I can tell you're only checking if "a value is defined in the current region or implicitly captured".

Isn't `areValuesDefinedAbove()` suitable here?

https://github.com/llvm/llvm-project/pull/154924