[Mlir-commits] [mlir] [mlir] Provide constexpr constructor for c++20 compat (PR #154887)

[Jordan Rupprecht]

https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/154887

>From 4083b32791e712d83acd39302001309f8b8575aa Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht <rupprecht at google.com>
Date: Thu, 21 Aug 2025 21:49:50 -0700
Subject: [PATCH 1/2] [mlir] Provide constexpr constructor for c++20 compat

---
 mlir/include/mlir/IR/Remarks.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/mlir/include/mlir/IR/Remarks.h b/mlir/include/mlir/IR/Remarks.h
index a737babc66115..fdae84d82c159 100644
--- a/mlir/include/mlir/IR/Remarks.h
+++ b/mlir/include/mlir/IR/Remarks.h
@@ -60,7 +60,12 @@ struct RemarkOpts {
   StringRef categoryName;    // Category name (subject to regex filtering)
   StringRef subCategoryName; // Subcategory name
   StringRef functionName;    // Function name if available
-  RemarkOpts() = delete;
+
+  constexpr RemarkOpts(StringRef remarkName, StringRef categoryName,
+                       StringRef subCategoryName, StringRef functionName)
+      : remarkName(remarkName), categoryName(categoryName),
+        subCategoryName(functionName), functionName(functionName) {}
+
   // Construct RemarkOpts from a remark name.
   static constexpr RemarkOpts name(StringRef n) {
     return RemarkOpts{n, {}, {}, {}};

>From ff6fefab6692501ae15bf7d768625a7f4fbc48e9 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht <rupprecht at google.com>
Date: Thu, 21 Aug 2025 22:19:58 -0700
Subject: [PATCH 2/2] Fix wrong constructor arg

---
 mlir/include/mlir/IR/Remarks.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mlir/include/mlir/IR/Remarks.h b/mlir/include/mlir/IR/Remarks.h
index fdae84d82c159..eed0d52827412 100644
--- a/mlir/include/mlir/IR/Remarks.h
+++ b/mlir/include/mlir/IR/Remarks.h
@@ -64,7 +64,7 @@ struct RemarkOpts {
   constexpr RemarkOpts(StringRef remarkName, StringRef categoryName,
                        StringRef subCategoryName, StringRef functionName)
       : remarkName(remarkName), categoryName(categoryName),
-        subCategoryName(functionName), functionName(functionName) {}
+        subCategoryName(subCategoryName), functionName(functionName) {}
 
   // Construct RemarkOpts from a remark name.
   static constexpr RemarkOpts name(StringRef n) {