[Mlir-commits] [mlir] [mlir] Fix missing `mlir-capi-global-constructors-test` on standalone build (PR #154576)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Wed Aug 20 10:20:36 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir
Author: Michał Górny (mgorny)
<details>
<summary>Changes</summary>
Add `mlir-capi-global-constructors-test` to `MLIR_TEST_DEPENDS` when `MLIR_ENABLE_EXECUTION_ENGINE` is enabled, to ensure that it is also built during standalone builds, and therefore fix test failure due to the executable being missing.
I don't understand the purpose of `LLVM_ENABLE_PIC AND TARGET ${LLVM_NATIVE_ARCH}` block, but the condition is not true in standalone builds.
Fixes 7610b1372955da55e3dc4e2eb1440f0304a56ac8.
---
Full diff: https://github.com/llvm/llvm-project/pull/154576.diff
1 Files Affected:
- (modified) mlir/test/CMakeLists.txt (+4-1)
``````````diff
diff --git a/mlir/test/CMakeLists.txt b/mlir/test/CMakeLists.txt
index 7736723ce2ae9..8ddc620ae33be 100644
--- a/mlir/test/CMakeLists.txt
+++ b/mlir/test/CMakeLists.txt
@@ -157,7 +157,10 @@ if(MLIR_ENABLE_CUDA_RUNNER)
endif()
if(MLIR_ENABLE_EXECUTION_ENGINE)
- list(APPEND MLIR_TEST_DEPENDS mlir-capi-execution-engine-test)
+ list(APPEND MLIR_TEST_DEPENDS
+ mlir-capi-execution-engine-test
+ mlir-capi-global-constructors-test
+ )
endif()
if(MLIR_ENABLE_ROCM_RUNNER)
``````````
</details>
https://github.com/llvm/llvm-project/pull/154576
More information about the Mlir-commits
mailing list