[Mlir-commits] [mlir] [mlir][IR] Fix `Block::without_terminator` for `NoTerminator` ops (PR #154498)

[Matthias Springer]

matthias-springer wrote:

This issue came up when I was debugging code in a downstream project. The code there iterated over all ops, except for the terminator (for dubious reasons...). The block belonged to an op with `NoTerminator`. `Block::without_terminator` did not include the last operation (when it should have).

I found a way to test this via `sortTopologically`: based on this API change, the implementation there can be simplified.


https://github.com/llvm/llvm-project/pull/154498