[Mlir-commits] [mlir] [MLIR][SCF] Actually use conversion interface in scf-to-cf conversion (PR #154075)

[William Moses]

wsmoses wrote:

yeah I guess at a high-level it's illegal to combine rewrite patterns and conversion patterns. Nearly every other pass inside of Conversion/ (the other exception MathToLibm.cpp I'm making a PR for concurrently) use conversion patterns. That alone imo merits the change, but re the segfault above -- this means that one cannot combine several conversion patterns in a single pass legally, at least without rewriting.

https://github.com/llvm/llvm-project/pull/154075