[Mlir-commits] [mlir] [MLIR][SCF] Actually use conversion interface in scf-to-cf conversion (PR #154075)

[Mehdi Amini]

joker-eph wrote:

Thanks for elaborating, but I still don't understand: is this something more specific we could describe here?

The debug trace shows a crash on null values in the folder, and then shows that this was created by a rollback in the conversion dialect infra?
You wrote "when using conversion patterns inside the greedy driver that doesn't provide sufficient rewriter infrastructure" while the issue would come from the dialect conversion here, so I don't quite follow.

Ping @matthias-springer who may help narrowing down the criteria that makes this needed to be an OpConversion.

(also I don't think the long debug trace belongs to the commit message)


https://github.com/llvm/llvm-project/pull/154075