[Mlir-commits] [mlir] Save unregistered attrs after type conversion. (PR #135084)

[Michael Kuperstein]

mkuperst wrote:

Reviving this - is there a strong reason not to land this?

I agree that the attributes are discardable in the sense that it's perfectly legal to discard them, but it's not like there's a mandate to discarded, it's just that they're preserved on a best-effort basis, and may be discarded when convenient. 

But given that the effort to preserve them here is very low, and as Jacques noted, is the less surprising behavior, it seems to me like it's worthwhile to preserve them here? Or is there any specific benefit to not preserving them here that I'm missing?

https://github.com/llvm/llvm-project/pull/135084