[Mlir-commits] [mlir] [MLIR][WASM] Introduce an importer for Wasm binaries (PR #152131)

[Luc Forget]

lforg37 wrote:

@joker-eph : I can't directly reply to your comments, so writing here.

> I fixed the leak here: https://github.com/llvm/llvm-project/pull/153794
> [...] can you check if that makes sense to you right now?

Yes, it makes sense. Thank you very much for fixing it.

> the second breakage is fixed here: https://github.com/llvm/llvm-project/pull/153795
> Please have a look, we can discuss separately on next steps if you need these.

I don't think we had specific reasons to use statistic, and for what we do with them at the moment, debug output is as good. 
Pinging @ornata to check if there was a reason I'm overlooking.  

 For the `symbols`, this is indeed a leftover from history rewriting. We do use it in later commits. This should be fixed by next PR.

Thanks again for the fixes. 

https://github.com/llvm/llvm-project/pull/152131