[Mlir-commits] [mlir] 3f797a8 - [mlir][spirv] Add missing #include in SPIRVImageInterfaces.h (#153727)

[llvmlistbot at llvm.org]

Author: Chenguang Wang
Date: 2025-08-14T19:07:54-07:00
New Revision: 3f797a8342c3dbe4a260b26f948d8776ff490431

URL: https://github.com/llvm/llvm-project/commit/3f797a8342c3dbe4a260b26f948d8776ff490431
DIFF: https://github.com/llvm/llvm-project/commit/3f797a8342c3dbe4a260b26f948d8776ff490431.diff

LOG: [mlir][spirv] Add missing #include in SPIRVImageInterfaces.h (#153727)

SPIRVImageInterfaces.h.inc uses some types, e.g. mlir::TypedValue,
without #include the necessary headers. This is fine most of the time,
but we did run into a weird case where bazel fails to compile
//mlir:SPIRVImageInterfaces on clang19 for ChromiumOS when parse_headers
(see [1]) is specified.

[1]: https://bazel.build/docs/bazel-and-cpp#toolchain-features

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/SPIRV/Interfaces/SPIRVImageInterfaces.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/SPIRV/Interfaces/SPIRVImageInterfaces.h b/mlir/include/mlir/Dialect/SPIRV/Interfaces/SPIRVImageInterfaces.h
index ca5a1dcd88171..0c70d4fafd246 100644
--- a/mlir/include/mlir/Dialect/SPIRV/Interfaces/SPIRVImageInterfaces.h
+++ b/mlir/include/mlir/Dialect/SPIRV/Interfaces/SPIRVImageInterfaces.h
@@ -9,6 +9,8 @@
 #ifndef MLIR_DIALECT_SPIRV_IMAGE_INTERFACES_H_
 #define MLIR_DIALECT_SPIRV_IMAGE_INTERFACES_H_
 
+#include "mlir/IR/OpDefinition.h"
+
 #include "mlir/Dialect/SPIRV/Interfaces/SPIRVImageInterfaces.h.inc"
 
 #endif // MLIR_DIALECT_SPIRV_IMAGE_INTERFACES_H_