[Mlir-commits] [mlir] [mlir][vector] Improve vector.gather description (PR #153278)

James Newling llvmlistbot at llvm.org
Thu Aug 14 08:44:22 PDT 2025


newling wrote:

> Taking a step back, we should probably rename the[ input arguments](https://github.com/llvm/llvm-project/blob/5ccc734fa0355f971f8f515457a0bece33ab6642/mlir/include/mlir/Dialect/Vector/IR/VectorOps.td#L2053-L2058) as:

> index -> offsets
> index_vec -> indices
> Have you thought about it?

I hadn't considered renaming variables, but those names would definitely be an improvement. 

https://github.com/llvm/llvm-project/pull/153278


More information about the Mlir-commits mailing list