[Mlir-commits] [mlir] [mlir] Added `Convergent` trait that matches LLVM's semantics (PR #152358)

[Nikolay Panchenko]

npanchen wrote:

> There is no jump threading in MLIR and your patch does not show any tests: so that's not a clear answer to "I'm not sure what is the actual issue in MLIR and how this patch solves it right now".

Yes, that's what I said [before too](https://github.com/llvm/llvm-project/pull/152358#discussion_r2258093928): there's no direct impact on MLIR, but it does impact optimizations done later on generated LLVM IR.
  
> As mentioned before: LLVM does not have structured control-flow, so all the definitions from LLVM need to be revisited.
> As mentioned before when I pointed what clang does: making it more generic requires new definitions and looking into the semantics we want for structured control-flow structure.

Ok, not to go over same things multiple times: do I get you right that for you such trait has to be defined from all possible angles (structured cf, functions, simple op) in a single PR ?

> That means you need to move all this away from mlir/include/mlir/Interfaces/ControlFlowInterfaces.h into the LLVM dialect.

Thanks, that looks reasonable to move it there.

https://github.com/llvm/llvm-project/pull/152358